Make NO ACTION the default action for foreign keys#1560
Open
samtay wants to merge 2 commits intoyesodweb:masterfrom
Open
Make NO ACTION the default action for foreign keys#1560samtay wants to merge 2 commits intoyesodweb:masterfrom
NO ACTION the default action for foreign keys#1560samtay wants to merge 2 commits intoyesodweb:masterfrom
Conversation
Collaborator
|
Sorry I've taken so long to get to this! I'm amenable to the rationale for the changes in this, however, I'd like to think through the upgrade path. If we release this as-is, then every Instead, it'd be better to do this in phases:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1416 for motivation, but tl;dr is that
NO ACTIONis a more sensible default across the supported databases.Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog